Liron Ar has posted comments on this change. Change subject: engine: Check for conflicting address when hotplugging a disk ......................................................................
Patch Set 10: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26598/10/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java: Line 103: Line 104: @Test Line 105: public void testGetVmDeviceByVmIdAndAddress() { Line 106: List<VmDevice> devices = dao.getVmDeviceByVmIdAndAddress(EXISTING_VM_ID, "sample"); Line 107: assertTrue("The list should not be empty", !devices.isEmpty()); sorry for forgetting to write this before, but when you rebase, i'd change this a bit - 1. verifying that the returned devices has the correct address. 2. add another test in which no devices should be returned. Line 108: } Line 109: Line 110: @Test Line 111: public void testGetVmDeviceByVmIdTypeAndDeviceFilteringWithoutPermissions() { -- To view, visit http://gerrit.ovirt.org/26598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
