Juan Hernandez has posted comments on this change. Change subject: restapi: Control virtio rng device ......................................................................
Patch Set 4: (6 comments) http://gerrit.ovirt.org/#/c/27157/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2485: <!-- Random Number Genertor device --> Line 2486: <xs:complexType name="Rate"> Line 2487: <xs:sequence> Line 2488: <xs:element name="bytes" type="xs:int" minOccurs="1" maxOccurs="1"/> Line 2489: <xs:element name="period" type="xs:int" minOccurs="0" maxOccurs="1"/> Can you please explain the purpose of these "bytes" and "period" parameters? Line 2490: </xs:sequence> Line 2491: </xs:complexType> Line 2492: Line 2493: <xs:element name="rng_device" type="RngDevice"/> Line 2494: Line 2495: <xs:complexType name="RngDevice"> Line 2496: <xs:sequence> Line 2497: <xs:element name="rate" type="Rate" minOccurs="0" maxOccurs="1"/> Line 2498: <xs:element name="source" type="xs:string" minOccurs="1" maxOccurs="1"/> What would be the possible values of "source"? Should we publish them in the /capabilities resource? Line 2499: </xs:sequence> Line 2500: </xs:complexType> Line 2501: Line 2502: <xs:complexType name="HighAvailability"> Line 2496: <xs:sequence> Line 2497: <xs:element name="rate" type="Rate" minOccurs="0" maxOccurs="1"/> Line 2498: <xs:element name="source" type="xs:string" minOccurs="1" maxOccurs="1"/> Line 2499: </xs:sequence> Line 2500: </xs:complexType> Remember to fix indentation before merging: two spaces per level. Line 2501: Line 2502: <xs:complexType name="HighAvailability"> Line 2503: <xs:sequence> Line 2504: <xs:element name="enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/> http://gerrit.ovirt.org/#/c/27157/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java: Line 131: UpdateVmTemplateParameters params = new UpdateVmTemplateParameters(updated); Line 132: if (incoming.isSetRngDevice()) { Line 133: params.setUpdateRngDevice(true); Line 134: params.setRngDevice(RngDeviceMapper.map(incoming.getRngDevice(), null)); Line 135: } Can we put this ^ logic in the mapper method that we are calling below? Line 136: return getMapper(modelType, UpdateVmTemplateParameters.class).map(incoming, params); Line 137: } Line 138: } Line 139: http://gerrit.ovirt.org/#/c/27157/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java: Line 73: import org.ovirt.engine.core.compat.Guid; Line 74: Line 75: Line 76: import static org.ovirt.engine.api.restapi.resource.BackendVmsResource.SUB_COLLECTIONS; Line 77: import static org.ovirt.engine.core.utils.Ticketing.generateOTP; I think that this shouldn't go in this patch. Line 78: Line 79: public class BackendVmResource extends Line 80: AbstractBackendActionableResource<VM, org.ovirt.engine.core.common.businessentities.VM> implements Line 81: VmResource { http://gerrit.ovirt.org/#/c/27157/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java: Line 51: import static org.easymock.EasyMock.eq; Line 52: import static org.easymock.EasyMock.expect; Line 53: import static org.ovirt.engine.api.restapi.test.util.TestHelper.eqActionParams; Line 54: import static org.ovirt.engine.api.restapi.test.util.TestHelper.eqQueryParams; Line 55: import static org.ovirt.engine.api.restapi.test.util.TestHelper.eqSearchParams; This doesn't belong in this patch. Line 56: Line 57: public abstract class AbstractBackendBaseTest extends Assert { Line 58: protected static final Guid[] GUIDS = { new Guid("00000000-0000-0000-0000-000000000000"), Line 59: new Guid("11111111-1111-1111-1111-111111111111"), -- To view, visit http://gerrit.ovirt.org/27157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I585ae1088bbe18af42bf374e3207d053ae71f166 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
