Alon Bar-Lev has posted comments on this change. Change subject: Provide a public key with ovirt-release rpms. ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/27186/1/ovirt-release-3.4/ovirt-release.spec.in File ovirt-release-3.4/ovirt-release.spec.in: Line 30: Line 31: License: ASL 2.0 Line 32: URL: http://www.ovirt.org Line 33: Source0: http://resources.ovirt.org/pub/src/%{package_name}/%{package_name}-%{package_version}.tar.gz Line 34: Source1: RPM-GPG-ovirt.public url Line 35: Line 36: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release} Line 37: BuildArch: noarch Line 38: Line 46: Line 47: Line 48: %prep Line 49: %setup -q -n "%{package_name}-%{package_version}" Line 50: install -pm 644 "%{SOURCE1}" "%{package_name}-%{package_version}" do not use -p without good reason Line 51: Line 52: %build Line 53: %configure Line 54: make "%{?_smp_mflags}" Line 58: rm -rf "%{buildroot}" Line 59: %make_install Line 60: #Allow ghost files Line 61: install -d 755 "%{buildroot}%{_sysconfdir}/yum.repos.d" Line 62: install -Dpm 644 "%{SOURCE1}" "%{buildroot}%{_sysconfdir}/pki/rpm-gpg/RPM-GPG-ovirt.public" do not use -p without good reason. I recommend install -d prior than using -D Line 63: touch "%{buildroot}%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}.repo" Line 64: touch "%{buildroot}%{_sysconfdir}/yum.repos.d/ovirt-%{ovirt_version}-dependencies.repo" Line 65: Line 66: %post -- To view, visit http://gerrit.ovirt.org/27186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c2b558d5d78c9d23dabf9a5dbfc06da3c1a5bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
