Mike Kolesnik has posted comments on this change. Change subject: webadmin: Extract external subnet model & widget ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25358/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 447: Line 448: boolean subnetValid = true; Line 449: if ((Boolean) getExport().getEntity() Line 450: && (StringUtils.isNotEmpty(getSubnetModel().getName().getEntity()) Line 451: || StringUtils.isNotEmpty(getSubnetModel().getCidr().getEntity()))) { > As we discussed, please add check box to indicate if the subnet is enabled. Done Line 452: subnetValid = getSubnetModel().validate(); Line 453: } Line 454: Line 455: boolean profilesValid = true; -- To view, visit http://gerrit.ovirt.org/25358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d9c34a1ceb8c92e8ff813301186a2f5c9f499b4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
