Shirly Radco has posted comments on this change. Change subject: reports: br47 report - added comments to queries ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/25060/6/packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/storage_domains_inventory_br47_files/storage_domains_inventory_br47_jrxml.data: Line 61: SELECT Line 62: storage_domain_name, Line 63: v3_4_configuration_history_storage_domains.storage_domain_id, Line 64: COALESCE ( a.value_localized, a.value ) AS storage_domain_type, Line 65: COALESCE ( b.value_localized, b.value ) AS storage_type, > put this variables in separate lines Done Line 66: -- The disk usage is usually calculated from the samples statistics table, Line 67: -- so it will be most accurate. Line 68: -- But if the data is not available from the samples Line 69: -- then the data will be taken from the daily statistics table Line 90: v3_4_configuration_history_storage_domains.storage_domain_id = Line 91: v3_4_map_history_datacenters_storage_domains.storage_domain_id Line 92: -- -- Here we filter by the datacenter chosen by the user Line 93: AND v3_4_map_history_datacenters_storage_domains.datacenter_id = Line 94: CAST ( $P{P_DataCenter_ID} AS uuid ) > should be indented with one more tab Done Line 95: AND v3_4_map_history_datacenters_storage_domains.history_id IN ( Line 96: SELECT MAX ( a.history_id ) Line 97: FROM v3_4_map_history_datacenters_storage_domains a Line 98: GROUP BY a.storage_domain_id, a.datacenter_id Line 180: -- Here we filter by the storage type chosen by the user Line 181: -- If "All" storage types were chosen by the user then the Line 182: -- parameter "P_Storage_Type" equals to -1 Line 183: storage_domain_type = Line 184: CASE $P{P_Storage_Type} > should be indented with one more tab Done Line 185: WHEN -1 Line 186: THEN storage_domain_type Line 187: ELSE $P{P_Storage_Type} Line 188: END -- To view, visit http://gerrit.ovirt.org/25060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce5b40141765d1e25637741b6c5a02b12b208b7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
