Shirly Radco has posted comments on this change. Change subject: history: updated etl process for scalablility ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/26952/12/tos_project/process/AggregationToDaily_3.4.item File tos_project/process/AggregationToDaily_3.4.item: Line 1651: <column defaultValue="" key="false" length="255" name="errorCode" nullable="true" precision="0" sourceType="" type="id_String" usefulColumn="true"/> Line 1652: <column defaultValue="" key="false" length="255" name="errorMessage" nullable="true" precision="0" sourceType="" type="id_String" usefulColumn="true"/> Line 1653: </metadata> Line 1654: </node> Line 1655: <node componentName="tJDBCInput" componentVersion="0.102" offsetLabelX="0" offsetLabelY="0" posX="256" posY="640"> > Why is this done twice? The father always passed this value to this job. Done Line 1656: <elementParameter field="TEXT" name="UNIQUE_NAME" value="tJDBCInput_6"/> Line 1657: <elementParameter field="CHECK" name="END_OF_FLOW" value="false"/> Line 1658: <elementParameter field="CHECK" name="USE_EXISTING_CONNECTION" value="true"/> Line 1659: <elementParameter field="COMPONENT_LIST" name="CONNECTION" value="tJDBCConnection_1"/> http://gerrit.ovirt.org/#/c/26952/12/tos_project/process/HourlyTimeKeepingJob_3.4.item File tos_project/process/HourlyTimeKeepingJob_3.4.item: Line 437: </node> Line 438: <node componentName="tRowGenerator" componentVersion="0.102" offsetLabelX="0" offsetLabelY="0" posX="448" posY="192"> Line 439: <elementParameter field="TEXT" name="UNIQUE_NAME" value="tRowGenerator_1"/> Line 440: <elementParameter field="CHECK" name="END_OF_FLOW" value="false"/> Line 441: <elementParameter field="TEXT" name="NB_ROWS" value="10"/> > Why is this component creating 10 rows? Done Line 442: <elementParameter field="TABLE" name="VALUES"> Line 443: <elementValue elementRef="SCHEMA_COLUMN" value="var_name"/> Line 444: <elementValue elementRef="ARRAY" value=""HourlyAggFailed" "/> Line 445: <elementValue elementRef="SCHEMA_COLUMN" value="var_value"/> -- To view, visit http://gerrit.ovirt.org/26952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d7e6f8ad7238456a1e9cd05396cce217fa02a39 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
