anmolbabu has posted comments on this change.

Change subject: engine : Set monitoring Environment variable in vdsDeploy
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27064/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java:

Line 456:         }},
Line 457:         new Callable<Object>() { public Object call() throws 
Exception {
Line 458:             VdsDeployConfigDAO vdsDeployConfigDao = 
DbFacade.getInstance().getVdsDeployConfigDao();
Line 459:             boolean monitoringEnabled = 
Boolean.parseBoolean(vdsDeployConfigDao.getByNameAndType("monitoring_enable", 
"Bool").getConfigValue());
Line 460:             String monitoringServerIp = 
vdsDeployConfigDao.getByNameAndType("monitoring_srvr_ip","String").getConfigValue();
> no... the whole pint is blindly add all vars from the table into the enviro
Done
Line 461:             
Line 462:             VDSGroup vdsGroup = 
DbFacade.getInstance().getVdsGroupDao().get(
Line 463:                 _vds.getVdsGroupId()
Line 464:             );


-- 
To view, visit http://gerrit.ovirt.org/27064
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f3371a9be9518579a14be0991180a840b01626
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to