Yair Zaslavsky has posted comments on this change. Change subject: core: SuperUser of DataCenter X cannot approve a host under this Data Center ......................................................................
Patch Set 1: Code-Review+2 (1 comment) minor comment. the logic sounds to me ok, feel free to fix and merge. http://gerrit.ovirt.org/#/c/27148/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java: Line 387: return getVdsGroup(); Line 388: } Line 389: Line 390: private VdsDynamic getVdsDynamic() { Line 391: return DbFacade.getInstance().getVdsDynamicDao().get(getVdsId()); you can simply perform getVds().getVdsDynamic() , as all commands still extend AuditLoggableBase, and it contains a getVds() method. Line 392: } Line 393: Line 394: private VDSGroup getTargetCluster() { Line 395: if (targetCluster == null) { -- To view, visit http://gerrit.ovirt.org/27148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59a51e4e3ebf184e0672a077b6dc0d16e60eb8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
