Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: backend: GetoVirtISOsQuery fix null for nodeOS
......................................................................

backend: GetoVirtISOsQuery fix null for nodeOS

This patch adds validation for nodeOS to avoid
the null error when we cannot collect hostOS.

Change-Id: If8ad4f88a079c7f25b544320e10f1d2b5c4190b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1076221
Signed-off-by: Douglas Schilling Landgraf <dougsl...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/27171/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
index 07da53e..dc6960c 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
@@ -43,6 +43,10 @@
 
         RpmVersion vdsOsVersion = VdsHandler.getOvirtHostOsVersion(vds);
         String nodeOS = vds.getHostOs();
+        if (nodeOS == null) {
+            getQueryReturnValue().setReturnValue(new ArrayList<RpmVersion>());
+            return;
+        }
         for (OVirtNodeInfo.Entry info : OVirtNodeInfo.getInstance().get()) {
             log.debugFormat(
                 "nodeOS [{0}] | osPattern [{1}] | minimumVersion [{2}]",


-- 
To view, visit http://gerrit.ovirt.org/27171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8ad4f88a079c7f25b544320e10f1d2b5c4190b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to