Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Removing build-conf files on failure ......................................................................
Patch Set 3: Verified-1 Made it append the transaction element also during _export so that a failure there is also rolled back correctly. However, this makes it fail :-( because the transaction prepare renames needed folders too early and so export fails. Not sure exactly how to solve this. I think the cleanest solution will be to have a temporary configuration for jasper used for the export only, using some temp folder and not /var/lib/ovirt-engine-reports/build-conf, and to create the final build-conf only during deploy. Did not try that yet. Or perhaps to use the legacy config (in /usr) when exporting from it. Or perhaps do a backup (copy) and not rename. -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
