Moti Asayag has posted comments on this change. Change subject: engine: add audit log warning when display network is set and a running VM is attached to the cluster (for AttachNetworksToCluster command). ......................................................................
Patch Set 6: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/26504/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 635 Line 636 Line 637 Line 638 Line 639 this could have been introduced in a separate patch. http://gerrit.ovirt.org/#/c/26504/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java: Line 71: updateNetworkAttachment( Line 72: getVdsGroupId(), Line 73: getNetworkCluster(), Line 74: getNetwork(), Line 75: AttachNetworkToVdsGroupCommand.this); I'd suggest to merge Lior's patch which was mentioned in the previous in-chain patch to reduce the changes to this patch. OR Just rebase on top of his patch which clears this soon-to-be-removed code. Line 76: return null; Line 77: } Line 78: }); Line 79: http://gerrit.ovirt.org/#/c/26504/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 773: if (throwable != null) { Line 774: setCallStack(ExceptionUtils.getStackTrace(throwable)); Line 775: } Line 776: } Line 777: this method is not okay: the AuditLogableBase should be capable to log itself, not any provided logable instance. For that purpose AuditLogDirector should be used. Line 778: public void auditLog(AuditLogableBase logable, AuditLogType logType) { Line 779: AuditLogDirector.log(logable, logType); Line 780: } Line 781: -- To view, visit http://gerrit.ovirt.org/26504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I674f7f7a905e3007e9857dd817e125e52d02c448 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
