Moti Asayag has posted comments on this change. Change subject: engine: Audit log warning about display network change. ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/26256/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/helper/DisplayNetworkClusterHelper.java: Line 14: Line 15: private final NetworkClusterDao networkClusterDao; Line 16: private final NetworkCluster networkCluster; Line 17: private final String networkName; Line 18: private final CommandBase<? extends VdcActionParametersBase> commandBase; this is just a command (and mainly not a command base which cannot be instantiated) Line 19: Line 20: private final ActiveVmAttachedToClusterPredicate activeVmAttachedToClusterPredicate; Line 21: Line 22: public DisplayNetworkClusterHelper( Line 46: Line 47: public void warnOnActiveVm() { Line 48: if (activeVmAttachedToClusterPredicate.eval(networkCluster.getClusterId())) { Line 49: AuditLogableBase loggable = createLoggable(); Line 50: commandBase.auditLog(loggable, AuditLogType.NETWORK_UPDATE_DISPLAY_FOR_CLUSTER_WITH_ACTIVE_VM); passing the command instance just for the logging capability doesn't seems right. A proper way would be using the AuditLogDirector.log() Line 51: } Line 52: } Line 53: Line 54: private AuditLogableBase createLoggable() { -- To view, visit http://gerrit.ovirt.org/26256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9df4cd96fe71b3a44132004f17a7889dbe912b2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
