Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: Make resize easier ......................................................................
Patch Set 1: Verified-1 (1 comment) Giving -1, it isn't broken. But I am going to do some more cleanup as part of this patch. There are a bunch of the same or almost the same css files that I think we can combine. http://gerrit.ovirt.org/#/c/27079/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java: Line 47: } Line 48: Line 49: private static final HeaderTemplate TEMPLATE = GWT.create(HeaderTemplate.class); Line 50: Line 51: private static final ResizableHeaderResources RESOURCES = GWT.create(ResizableHeaderResources.class); > It might be a plan to have these injected instead of instantiated like this Brain wasn't functioning when I wrote that, since this is static it only gets created once. Line 52: Line 53: // Width of the column header resize bar area, in pixels Line 54: private static final int RESIZE_BAR_WIDTH = 7; Line 55: -- To view, visit http://gerrit.ovirt.org/27079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24259a9aa5c68a25a9ae8b3d0d1553190bec3441 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
