Michael Pasternak has posted comments on this change.

Change subject: cli: Escape comma in values
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27078/1/src/ovirtcli/command/command.py
File src/ovirtcli/command/command.py:

Line 512:     def __split_with_escape(self, text, delimiter=',', escape='\\'):
Line 513:         """
Line 514:         Splits a string so that the delimiter is ignored if it is 
preceded by
Line 515:         the escape character.
Line 516:         """
i think you can do the same with single line of regex
Line 517: 
Line 518:         chunks = []
Line 519:         chunk = ''
Line 520:         escaping = False


-- 
To view, visit http://gerrit.ovirt.org/27078
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bcc5944e3f4236b3495acc02801acae7ec82eb2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to