Lior Vernia has posted comments on this change. Change subject: engine: Block change to old cluster if network properties set ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26645/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java: Line 140: Line 141: if (FeatureSupported.networkCustomProperties(getSourceCluster().getcompatibility_version()) Line 142: && !FeatureSupported.networkCustomProperties(getTargetCluster().getcompatibility_version())) { Line 143: for (VdsNetworkInterface iface : getHostNics()) { Line 144: if (iface.getCustomProperties() != null) { > any chance the customProperties will be an empty collection ? Done Line 145: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_CUSTOM_PROPERTIES_NOT_SUPPORTED, Line 146: String.format("$ACTION_TYPE_FAILED_NETWORK_CUSTOM_PROPERTIES_NOT_SUPPORTED_LIST %s", Line 147: iface.getNetworkName())); Line 148: } -- To view, visit http://gerrit.ovirt.org/26645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16622d0374bde7ab2e440d81d82e830ad8d81949 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
