Juan Hernandez has posted comments on this change. Change subject: restapi: Malformed GUID - fail gracefully (#902073) ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27140/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java: Line 289: throw new MalformedIdException(e); Line 290: } Line 291: } Line 292: Line 293: protected Guid asGuid(byte[] guid, boolean keepByteOrder) { Any reason to not make this static (and the other "asWhatever" methods as well)? Line 294: try { Line 295: return new Guid(guid, keepByteOrder); Line 296: } catch (IllegalArgumentException e) { Line 297: throw new MalformedIdException(e); -- To view, visit http://gerrit.ovirt.org/27140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf2d4db9b5e30a86b5eb2bb3071612a48867a646 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
