Lior Vernia has posted comments on this change. Change subject: engine,webadmin: Replace the call to deprecated UpdateDisplayToVdsGroup command with AttachNetworkToVdsGroup one ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26505/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java: Line 145: network.getCluster().setDisplay(true); Line 146: final AttachNetworkToVdsGroupParameter attachNetworkToVdcGroupParameter = Line 147: new AttachNetworkToVdsGroupParameter(getEntity(), network); Line 148: Line 149: Frontend.getInstance().runAction(VdcActionType.AttachNetworkToVdsGroup, attachNetworkToVdcGroupParameter); I think the right command to run in this context is UpdateNetworkOnCluster, if the network is already attached to the cluster and only gets the display role. What do you think? Line 150: } Line 151: Line 152: public void manage() { Line 153: if (getWindow() != null) { -- To view, visit http://gerrit.ovirt.org/26505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f103f0db10a06b0b2689298d3bfa505f4615577 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
