Daniel Erez has posted comments on this change. Change subject: webadmin: Block adding of mixed domain to a pool if not supported by version ......................................................................
Patch Set 9: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/26983/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java: Line 109: boolean isIsoDomain = item.getRole() == StorageDomainType.ISO; Line 110: boolean canAttachIsoDomain = isNoExportOrIsoStorageAttached && Line 111: dataCenter.getStatus() != StoragePoolStatus.Uninitialized; Line 112: Line 113: if (isExportDomain && canAttachExportDomain || isIsoDomain && canAttachIsoDomain) { consider adding inner parentheses (just for readability..) Line 114: updateItemSelectability(item, true); Line 115: return; Line 116: } Line 117: Line 131: @Override Line 132: public void onSuccess(Object model, Object ReturnValue) { Line 133: List<StorageType> storageTypes = ((VdcQueryReturnValue) ReturnValue).getReturnValue(); Line 134: for (StorageType storageType : storageTypes) { Line 135: if (storageType.isBlockDomain() != item.getType().isBlockDomain()) { isn't it sufficient to merely compare the storage type (as we prevented any sort of mixing before 'MixedStorageDomains')? Or, do we still prefer to do best effort and allow iSCSI mixed with FC for exmple? Line 136: updateItemSelectability(item, false); Line 137: return; Line 138: } Line 139: } -- To view, visit http://gerrit.ovirt.org/26983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib31884e6fd5a7868e9bb21c9566bcd2e445de52a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
