Tal Nisan has posted comments on this change. Change subject: webadmin: Storage Snapshots sub-tab ......................................................................
Patch Set 7: Code-Review+2 (2 comments) Minor issues, other than that - acked & verified http://gerrit.ovirt.org/#/c/26329/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageSnapshotListModel.java: Line 116: } Line 117: Line 118: private void updateActionAvailability() { Line 119: ArrayList<DiskImage> disks = getSelectedItems() != null ? Line 120: Linq.<DiskImage> cast(getSelectedItems()) : new ArrayList<DiskImage>(); Allocating a new array list every time selected items are changing from a selection to null selection? A bit overkill imo, perhaps leave it as null and let the isRemoveCommandAvailable return false if the disks are null? Line 121: Line 122: getRemoveCommand().setIsExecutionAllowed(disks.size() > 0 && isRemoveCommandAvailable(disks)); Line 123: } Line 124: Line 127: boolean isImageLocked = disk.getImageStatus() == ImageStatus.LOCKED; Line 128: boolean isTemplateType = disk.getVmEntityType().isTemplateType(); Line 129: Line 130: if (isImageLocked || isTemplateType) { Line 131: return false; Not that the VM status is not taken into consideration here (out of obviously reasons), make sure that the CDA is blocking it for status which is not down (that is until we'll have live merge of course :) ) Line 132: } Line 133: } Line 134: Line 135: return true; -- To view, visit http://gerrit.ovirt.org/26329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I888dad6a3f7ac876a859ce5e8e371599d0873b22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
