Allon Mureinik has posted comments on this change.
Change subject: core: Define GetDeviceList as User query
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
StoragePoolDAOTest tests the wrong dao method.
Otherwise, +1.
....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 192:
v_user_id and v_is_filtered use the proper psql convention.
Even thought it was already present, I'd consider renaming v_vdsId to v_vds_id.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java
Line 128: public void testGetForVdsFilteredWithPermissions() {
s/get/getForVds/
Line 134: @Test
s/get/getForVds/
Line 142: public void
testGetForVdsFilteredWithPermissionsNoPermissionsAndNoFilter() {
s/get/getForVds/
--
To view, visit http://gerrit.ovirt.org/5046
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7efa40ec62d16b75e2d70d73789b5d2c2aec587
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
