Alon Bar-Lev has posted comments on this change. Change subject: aaa: Using extensions API ......................................................................
Patch Set 42: (1 comment) http://gerrit.ovirt.org/#/c/26602/42/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java: Line 28: Line 29: String loginName = getLoginName(); Line 30: if (!loginName.contains("@")) { Line 31: loginName = loginName + "@" + getDomain(); Line 32: } the principal should be with the @xxxx Line 33: queryData.setLdapQueryType(LdapQueryType.getUserByPrincipalName); Line 34: // The domain in the UPN must overwrite the domain field. Discrepancies between the UPN domain and Line 35: // the domain may lead failure in Kerberos queries Line 36: String[] loginNameParts = loginName.split("@"); -- To view, visit http://gerrit.ovirt.org/26602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I916012eab61a96bdb0f366d9dc8462325d7f726f Gerrit-PatchSet: 42 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
