Moti Asayag has posted comments on this change. Change subject: userportal,webadmin: macPool per DC, textbox for pool configuration ......................................................................
Patch Set 2: Code-Review-1 (1 comment) 1. Please separate this patch into 2 modules: restapi and webadmin. 2. This patch requires changes for the AddStoragePoolCommand and UpdateStoragePoolCommand to validate the provided ranges on the engine side. If this code appears in a later patches - they should precede this patch. More comments inside. http://gerrit.ovirt.org/#/c/26796/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 1191: <xs:element name="storage_format" type="xs:string" minOccurs="0" /> Line 1192: <xs:element name="version" type="Version" minOccurs="0" /> Line 1193: <xs:element name="supported_versions" type="SupportedVersions" minOccurs="0" /> Line 1194: <xs:element ref="status" minOccurs="0" maxOccurs="1" /> Line 1195: <xs:element ref="mac_pool_ranges" minOccurs="0" maxOccurs="1"/> do you expect it to be reused ? since it is just a simple string, why not adding it as a simple element ? <xs:element name="mac_pool_ranges" type="xs:string" minOccurs="0" maxOccurs="1"/> I just wonder if Juan (restapi maintainer) will be ok with this convention of having multiple values per element. Please extract all rest-api changes into a separate patch and add Juan (jhernand) as a reviewer. Also, add a section of the restapi changes to the feature page. The SDK/Cli are based on the api, therefore having that section will aid users to understand how to use the mac ranges via the api. Line 1196: <!-- also rel="files" and rel="storagedomains" links --> Line 1197: </xs:sequence> Line 1198: </xs:extension> Line 1199: </xs:complexContent> -- To view, visit http://gerrit.ovirt.org/26796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id36188ef4b51d9b255c2adf230ca20bcf5979513 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
