Yair Zaslavsky has posted comments on this change. Change subject: core: fluenly return logable when adding custom value ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://en.wikipedia.org/wiki/Method_chaining#Java Please use this term in the commit message. Besides that , good idea. http://gerrit.ovirt.org/#/c/26584/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-04-09 10:29:14 +0300 Line 4: Commit: Roy Golan <rgo...@redhat.com> Line 5: CommitDate: 2014-04-09 04:00:47 -0400 Line 6: Line 7: core: fluenly return logable when adding custom value > fluently and why not use the term method chaining? Line 8: Line 9: basically this means we could: Line 10: Line 11: AuditLogDirector.log( http://gerrit.ovirt.org/#/c/26584/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 448: TransactionSupport.resume(transaction); Line 449: } Line 450: } Line 451: Line 452: public AuditLogableBase addCustomValue(final String name, final String value) { good job. Line 453: allocateCustomValues(); Line 454: customValues.put(name.toLowerCase(), value); Line 455: return this; Line 456: } -- To view, visit http://gerrit.ovirt.org/26584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibba14b4dd5ad520ea452ea940e9106c28cc5e4d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
