Allon Mureinik has posted comments on this change. Change subject: core: Added a query to fetch storage types in a storage pool ......................................................................
Patch Set 7: Code-Review+1 (1 comment) Looks good, but please check the unit test failure jenkins in complaining about. http://gerrit.ovirt.org/#/c/26981/7/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java: Line 157: private void testAddingMixedTypes(Version version, boolean addingMixedTypesShouldSucceed) { Line 158: storagePool.setcompatibility_version(version); Line 159: Line 160: // This will make the storage pool show as if he already has an NFS domain attached Line 161: when(storagePoolDAO.getStorageTypesInPool(storagePool.getId())).thenReturn(Arrays.asList(StorageType.NFS)); Please use Collections.singletonList Line 162: Line 163: StorageDomain domainToAttach = createValidStorageDomain(); Line 164: domainToAttach.setStorageFormat(cmd.getSupportedStorageFormatSet(version).iterator().next()); Line 165: initCommand(); -- To view, visit http://gerrit.ovirt.org/26981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97447e0fc3e087958101156947bded12c1fb9418 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
