Alon Bar-Lev has posted comments on this change. Change subject: core: Added the table vds_deloy_config ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27028/3/packaging/dbscripts/upgrade/03_05_0330_create_vds_deploy_config_table.sql File packaging/dbscripts/upgrade/03_05_0330_create_vds_deploy_config_table.sql: Line 1: -- create vds_deploy_config table Line 2: CREATE SEQUENCE vds_deploy_config_seq INCREMENT BY 1 START WITH 1; Line 3: CREATE TABLE vds_deploy_config Line 4: ( Line 5: cfg_id integer DEFAULT nextval('vds_deploy_config_seq'::regclass) NOT NULL, please be consistent tabs/space Line 6: cfg_name VARCHAR(128) NOT NULL, Line 7: cfg_type VARCHAR(32) NOT NULL, Line 8: cfg_value VARCHAR(4000) NOT NULL Line 9: ); Line 4: ( Line 5: cfg_id integer DEFAULT nextval('vds_deploy_config_seq'::regclass) NOT NULL, Line 6: cfg_name VARCHAR(128) NOT NULL, Line 7: cfg_type VARCHAR(32) NOT NULL, Line 8: cfg_value VARCHAR(4000) NOT NULL can we have host field? host as string that may be null or regexp? if null - apply to all, if regexp apply by host name? Line 9: ); Line 10: Line 11: -- create index for cfg_name Line 12: CREATE unique INDEX IDX_vds_deploy_config_cfg_name ON vds_deploy_config(cfg_name); -- To view, visit http://gerrit.ovirt.org/27028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
