Daniel Erez has posted comments on this change. Change subject: webadmin: Support column sorting ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25910/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterClusterView.java: Line 34: } Line 35: }; Line 36: nameColumn.makeSortable(new Comparator<VDSGroup>() { Line 37: @Override Line 38: public int compare(VDSGroup a, VDSGroup b) { * Can we add to the infrastructure some flag/mechanism for indicating whether the list should be sorted ascending or descending - as for this example, sorting is not functional since the comperator's order is constant... * Just a note for after merging the infrastructure - we probably should reuse comparators from Linq class or some other helper. Line 39: if (a == b) { Line 40: return 0; Line 41: } else if (a == null) { Line 42: return -1; -- To view, visit http://gerrit.ovirt.org/25910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I141ea068fe90409852d34bea6fedb45d0d8a07ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
