Juan Hernandez has posted comments on this change.
Change subject: restapi: Fix typo
......................................................................
Patch Set 1:
Fixing this typo means that the JAXB compiler will start to take into account
the annotation. As a result the names of the "getPmProxy()" method in the
"PmProxies" class will change to "getPmProxies()", thus breaking the places
where it is used, for example in "HostMapper" we currently have the following:
for (PmProxy pmProxy : model.getPmProxies().getPmProxy()) {
...
}
And it would need to be changed to the following:
for (PmProxy pmProxy : model.getPmProxies().getPmProxy()) {
...
}
Same in "HostValidator" and in the test of "HostMapper", maybe in other places.
Not a big deal, can be included in your patch. However the Java SDK also uses
the .xsd to generate code, and there we can't change the names of methods, as
that breaks backwards compatibility.
All in all, I think that we should fix the typo, but just removing completely
the annotation.
--
To view, visit http://gerrit.ovirt.org/27008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3780ff5c186227420f62d5434f8d241c9618988e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
