Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Added usage of AuthRecord.VALID_TO
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/26975/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java:

Line 280:             }
Line 281:             softLimit =
Line 282:                     DateUtils.addMinutes(softLimit,
Line 283:                             Config.<Integer> 
getValue(ConfigValues.UserSessionTimeOutInterval));
Line 284:             
sessionInfo.contentOfSession.put(SOFT_LIMIT_PARAMETER_NAME, softLimit);
> i thought that if softLimit is not null, you add x to softLimit, not to "no
no... you just set refresh to now + soft limit

you do not care what it was before, it only required to keep session alive.
Line 285:         }
Line 286:     }
Line 287: 


-- 
To view, visit http://gerrit.ovirt.org/26975
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e4a371c1bae8d2480ddd2af921a560c6fe9a85
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to