Lior Vernia has posted comments on this change. Change subject: engine: Consider removed bonds in CollectVdsNetworkData ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26926/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java: Line 210: Line 211: @Override Line 212: public Boolean runInTransaction() { Line 213: // save the new network topology to DB Line 214: List<VdsNetworkInterface> ifaces = new ArrayList<VdsNetworkInterface>(getInterfaces()); > no need for declaring the type for the ArrayList, the following is enough: Done Line 215: ifaces.addAll(getRemovedBonds().values()); Line 216: Backend.getInstance().getResourceManager() Line 217: .RunVdsCommand(VDSCommandType.CollectVdsNetworkData, Line 218: new CollectHostNetworkDataVdsCommandParameters(getVds(), ifaces)); -- To view, visit http://gerrit.ovirt.org/26926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44f1d5c0702e5062fe29bc89e12ff2400b46921b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
