Daniel Erez has posted comments on this change. Change subject: core: DiskImagesValidator - validate images belong to same Disk ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26448/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java: Line 191: Line 192: return ValidationResult.VALID; Line 193: } Line 194: Line 195: public ValidationResult diskImagesBelongToSameImageGroup() { > perhaps you can return more informative message here to the user so he can I prefer to re-visit this issue later on since it adds a complexity of checking the entire list instead of returning after the first detected conflict (and for now the UI actually handles it internally anyway...). Line 196: Guid imageGroupId = null; Line 197: for (DiskImage diskImage : diskImages) { Line 198: if (imageGroupId == null || diskImage.getId().equals(imageGroupId)) { Line 199: imageGroupId = diskImage.getId(); -- To view, visit http://gerrit.ovirt.org/26448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c4a31cbe3d93f582b710910dd9cd1a51ab50b2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
