Yair Zaslavsky has posted comments on this change. Change subject: aaa: Added usage of AuthRecord.VALID_TO ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/26975/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java: Line 96: softLimit = now; Line 97: sessionInfo.sessionMap.put(LAST_REFRESH, softLimit); Line 98: } Line 99: Line 100: // We add at most 2 * UserSessionTimeOutInterval minutes to soft limit, depends on the last refresh I preferred to mimic the old behavior as much as possible. IMHO, refresh should not always add the same amount of time to soft limit. in the old implementation, the fact that the session was moved to the "new generation" means that at most 2 * UserSessionTimeOutInterval was added to its expiration time. Also notice that if refresh is true, and the the session is already a member of the "new generation" there is no change to the expiration -> this is why I calculate how many "intervals" to add to the softLimit in the new implementation. Line 101: // time. This is to mimic the old behavior of refresh flag Line 102: long minutesSinceLastRefresh = Line 103: (now.getTime() - ((Date) sessionInfo.sessionMap.get(LAST_REFRESH)).getTime()) / 60000; Line 104: int numberOfIntervalsToAdd = -- To view, visit http://gerrit.ovirt.org/26975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e4a371c1bae8d2480ddd2af921a560c6fe9a85 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
