Vojtech Szocs has posted comments on this change. Change subject: webadmin: Filter search objects according to ApplicationMode ......................................................................
Patch Set 2: > isn't it better to only allow search entity that corresponding tabs are > available? You mean that we should check all main tab models (CommonModel child models) if the search suggestion matches their search string, and if the model is not available, exclude the suggestion? This sounds reasonable. My original patch just filtered search objects based on ApplicationMode, since UiCommon models are not really related to search suggestions (SearchObjects class). I agree with your point and will update my patch. -- To view, visit http://gerrit.ovirt.org/4966 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4651337c35ed278640671a477d1e85439c8799fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
