Moti Asayag has posted comments on this change. Change subject: core: Support decreasing dc compatbility version ......................................................................
Patch Set 7: (2 comments) there are only minor comments. By looking at the current message of compatibility version decrease failure, I tend to believe the user will not get the exact indication what prevents from decreasing the version. The current message is too generic: "Cannot decrease data center compatibility version." Please note that the same message also used for UpdateVdsGroupCommand for cluster version decrease which isn't correct (missed that on the previous patch) http://gerrit.ovirt.org/#/c/26947/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 206: || !validator.canNetworkCompatabilityBeDecreased()) { Line 207: returnValue = false; Line 208: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 209: } Line 210: } else if (!networks.isEmpty()) { would you mind changing this condition to if (networks.size() > 1) { ... } since it will better reflect the intention of this part. Line 211: returnValue = false; Line 212: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 213: } Line 214: } http://gerrit.ovirt.org/#/c/26947/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java: Line 216: storagePool s/storagePool/dataCenter -- To view, visit http://gerrit.ovirt.org/26947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb99e4773ee5592483ad055b277641ebc63cae1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
