Michael Pasternak has posted comments on this change. Change subject: restapi: Add Vm Ballooning Support ......................................................................
Patch Set 1: (3 inline comments) i'm not sure i agree with modelling of this feature .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 921: <xs:element name="overcommit" type="MemoryOverCommit" minOccurs="0" maxOccurs="1"> white-space Line 1895: <xs:element ref="usb" minOccurs="0" maxOccurs="1"/> white-space .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java Line 336: true); why this is query rather than another vm property, say i have 1000 vms in system, to list them all at /api/vms i need to run 1000 extra queries? -- To view, visit http://gerrit.ovirt.org/5013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ae28e645c7236dbf0f1dad50b409609c44549e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
