Alon Bar-Lev has posted comments on this change. Change subject: aaa: Ensure profiles are created after extensions initialization ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26934/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 69: createProfiles(); Line 70: } Line 71: Line 72: private void createProfiles() throws ConfigurationException { Line 73: ExtensionsManager.getInstance().dump(); this should not be here, dump should be done within the init bead or within the extension manager for each extension loaded please remember that we want extension manager to be used for other tasks than aaa Line 74: Line 75: // Get the extensions that correspond to authn (authentication) service. Line 76: // For each extension - get the relevant authn extension. Line 77: -- To view, visit http://gerrit.ovirt.org/26934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94663da1fff1609998fd3be280077d2e25f1f062 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
