Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Added usage of AuthRecord.VALID_TO
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/26975/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java:

Line 126:                     DateUtils.addMinutes(new Date(), Config.<Integer> 
getValue(ConfigValues.UserSessionTimeOutInterval));
Line 127:             try {
Line 128:                 Date fromExtension =
Line 129:                         new SimpleDateFormat("yyyy-MM-dd 
HH:mm:ssZ").parse(authRecord.<String> get(AuthRecord.VALID_TO));
Line 130:                 validTo = validTo.compareTo(fromExtension) < 0 ? 
validTo : fromExtension;
> if engine sets valid to - how it is passed to the provider? i thought it's 
simple:

 auth_record = authenticate()
 if I_want_to_update_valid_to_as_I_have_shorter_time_restriction {
     auth_record.put(VALID_TO, whatever_I_want)
 }
Line 131:             } catch (ParseException e) {
Line 132:                 log.warn("Error parsing AuthRecord.VALID_TO . Default 
VALID_TO value will be set on session");
Line 133:             }
Line 134:             SessionDataContainer.getInstance().setValidTo(validTo);


-- 
To view, visit http://gerrit.ovirt.org/26975
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e4a371c1bae8d2480ddd2af921a560c6fe9a85
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to