Eli Mesika has posted comments on this change. Change subject: core: Support decreasing dc compatbility version ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26947/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 202: Line 203: Network network = networks.get(0); Line 204: NetworkValidator validator = getNetworkValidator(network); Line 205: if (networks.size() != 1 || !NetworkUtils.isManagementNetwork(networks.get(0)) Line 206: || !validator.vmNetworkSetCorrectly().isValid() || !validator.mtuValid().isValid()) { I expect the validator to encapsulate vmNetworkSetCorrectl & mtuValid in a boolean method. Features will be added in next releases and we don't want to change this code (or even worse , forget to change this code ) Line 207: returnValue = false; Line 208: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); Line 209: } Line 210: } -- To view, visit http://gerrit.ovirt.org/26947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb99e4773ee5592483ad055b277641ebc63cae1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
