Alexander Wels has uploaded a new change for review. Change subject: core: StoragePool equals problem ......................................................................
core: StoragePool equals problem - On a blank default data center, showing the subtabs would cause the loading indicator to show every refresh period. This was due to an issue in the storage pool class that caused the equals to return false when it should be true. This patch fixes that issue. Change-Id: I5ae44a6ea127b4e3b35647721fd2e927bac130b6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073041 Signed-off-by: Alexander Wels <aw...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/26972/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java index 436fa51..269dd52 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java @@ -26,7 +26,7 @@ groups = { CreateEntity.class, UpdateEntity.class }) private String description; - private String comment; + private String comment = ""; private boolean local; @@ -72,15 +72,14 @@ this.description = value; } + @Override public String getComment() { - if (comment == null) { - comment = ""; - } return comment; } + @Override public void setComment(String value) { - this.comment = value; + this.comment = (value == null) ? "" : value; } @Override -- To view, visit http://gerrit.ovirt.org/26972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ae44a6ea127b4e3b35647721fd2e927bac130b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Alexander Wels <aw...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
