Moti Asayag has posted comments on this change. Change subject: core: Allow decreasing a cluster compatability version ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26940/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 180: // decreasing of compatibility version is only allowed when no hosts exists, and not beneath the DC version Line 181: if (result && getVdsGroup().getcompatibility_version().compareTo(oldGroup.getcompatibility_version()) < 0) { Line 182: if (!allForVdsGroup.isEmpty()) { Line 183: result = false; Line 184: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION Please use addCanDoActionMessage(VdcBllMessages) instead of addCanDoActionMessage(String) which mainly used for replacements. Line 185: .toString()); Line 186: } Line 187: Line 188: if (oldGroup.getStoragePoolId() != null) { Line 194: toString same here -- To view, visit http://gerrit.ovirt.org/26940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a8f52c63a82871e4ac1847f0414c82095f43075 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
