Juan Hernandez has posted comments on this change. Change subject: rest: retrieve disk snapshots list by storage domain ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Please consider renaming the XML elements to disk_snapshot and disk_snapshots. http://gerrit.ovirt.org/#/c/26730/3/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2946: <xs:element name="disks" type="Disks"/> Line 2947: Line 2948: <xs:element name="disksnapshot" type="DiskSnapshot"/> Line 2949: Line 2950: <xs:element name="disksnapshots" type="DiskSnapshots"/> For XML elements we usually use underscores to separate words. Can you rename these elements to "disk_snapshot" and "disk_snapshots"? Line 2951: Line 2952: <xs:element name="nic" type="NIC"/> Line 2953: Line 2954: <xs:element name="nics" type="Nics"/> -- To view, visit http://gerrit.ovirt.org/26730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5359c5df490c7e7e6f9b4d25e794bd07c6877339 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
