Federico Simoncelli has posted comments on this change. Change subject: engine: Check for conflicting address when hotplugging a disk ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26598/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java: Line 141: getVmStaticDAO().incrementDbGeneration(getVm().getId()); Line 142: setSucceeded(true); Line 143: } Line 144: Line 145: private void updateAddressAlreadyInUse() { I think this should be "clearAddressAlreadyInUse()" or something similar. Line 146: List<VmDevice> devices = getVmDeviceDao().getVmDeviceByVmIdAndType(getVmId(), oldVmDevice.getType()); Line 147: for (VmDevice device : devices) { Line 148: if (device.getIsPlugged() && oldVmDevice.getAddress().equals(device.getAddress())) { Line 149: getVmDeviceDao().clearDeviceAddress(oldVmDevice.getDeviceId()); -- To view, visit http://gerrit.ovirt.org/26598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5850fd4c15a230dbc27e8c22d47935083da21c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Xavi Francisco <xfran...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
