Sandro Bonazzola has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/26878/2/src/ovirt_hosted_engine_setup/check_liveliness.py File src/ovirt_hosted_engine_setup/check_liveliness.py: Line 48: self.logger.debug('Acquiring ca.crt from the engine') Line 49: with contextlib.closing( Line 50: urllib2.urlopen( Line 51: 'http://{fqdn}/ca.crt'.format( Line 52: fqdn=fqdn, > if this localhost, please use localhost, not sure. Engine is not running on localhost, it's running on a VM. This is executed on a host managed by the engine. Line 53: ) Line 54: ) Line 55: ) as urlObj: Line 56: content = urlObj.read() Line 79: self._ovirtsdk_api.API( Line 80: url='https://{fqdn}/ovirt-engine/api'.format( Line 81: # should we also handle installation over Line 82: # non standar port? Line 83: fqdn=fqdn, > again... if it can be localhost, I suggest use localhost and insecure as we it can't be localhost Line 84: ), Line 85: username='admin@internal', Line 86: password=self.environment[ Line 87: ohostedcons.EngineEnv.ADMIN_PASSWORD, -- To view, visit http://gerrit.ovirt.org/26878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3522ccb82eee4bf7f04ded012d9badc97c55b5a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
