Alon Bar-Lev has posted comments on this change. Change subject: aaa: ExtensionsManager: use the new extension api ......................................................................
Patch Set 32: (2 comments) http://gerrit.ovirt.org/#/c/26427/32/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 15: Line 16: public class AuthenticationProfileRepository { Line 17: Line 18: private static final String AUTHN_SERVICE = Authn.class.getName(); Line 19: private static final String AUTHN_AUTHZ_PLUGIN = Authz.class.getName(); this should be reverted Line 20: Line 21: Line 22: private static volatile AuthenticationProfileRepository instance = null; Line 23: private Map<String, AuthenticationProfile> profiles = new HashMap<String, AuthenticationProfile>(); http://gerrit.ovirt.org/#/c/26427/32/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 116: authConfig.put(Base.ConfigKeys.MODULE, "org.ovirt.engine.extensions.builtin"); Line 117: authConfig.put(Base.ConfigKeys.CLASS, Line 118: "org.ovirt.engine.extensions.aaa.builtin.internal.InternalAuthenticator"); Line 119: authConfig.put("ovirt.engine.aaa.authn.profile.name", "internal"); Line 120: authConfig.put(Authz.class.getName(), "internal"); should be reverted Line 121: authConfig.put("config.authn.user.name", Config.<String> getValue(ConfigValues.AdminUser)); Line 122: authConfig.put("config.authn.user.password", Config.<String> getValue(ConfigValues.AdminPassword)); Line 123: authConfig.put(Base.ConfigKeys.SENSITIVE_KEYS, "config.authn.user.password)"); Line 124: ExtensionsManager.getInstance().load(authConfig); -- To view, visit http://gerrit.ovirt.org/26427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d170d5dda990fd85e9843ecbb4909749a88df75 Gerrit-PatchSet: 32 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
