Douglas Schilling Landgraf has posted comments on this change. Change subject: db: 0000_config.sql - update OvirtIsoPrefix ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26630/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 393: select fn_db_add_config_value('OriginType','OVIRT','general'); Line 394: select fn_db_add_config_value('OvfVirtualSystemType','ENGINE','general'); Line 395: --Handling The ovirt-node installation files path Line 396: select fn_db_add_config_value('OvirtInitialSupportedIsoVersion','2.5.5:5.8','general'); Line 397: select fn_db_add_config_value('OvirtIsoPrefix','^ovirt-node-iso-([0-9].*)\.iso$:^rhevh-([0-9].*)\.iso$','general'); > please elaborate why this fixes the bug. Regex was not accurate to get the isos. In downstream we see isos like rhevh-lastest-6.iso which the previous regex could match it. So the approach is get only isos that start with this suffix and a number of iso. Line 398: select fn_db_add_config_value('OvirtNodeOS','^ovirt.*$:^rhev.*$','general'); Line 399: select fn_db_add_config_value('oVirtISOsRepositoryPath','/usr/share/ovirt-node-iso:/usr/share/rhev-hypervisor','general'); Line 400: select fn_db_add_config_value('oVirtUpgradeScriptName','/usr/share/vdsm-reg/vdsm-upgrade','general'); Line 401: select fn_db_add_config_value('oVirtUploadPath','/data/updates/ovirt-node-image.iso','general'); -- To view, visit http://gerrit.ovirt.org/26630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ad1403b4afc8e6a5500c910560172395ee31fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
