Yair Zaslavsky has posted comments on this change. Change subject: engine : Modify Async_tasks table to use CommandEntity ......................................................................
Patch Set 4: (1 comment) dont forget we need to discuss upgrade. http://gerrit.ovirt.org/#/c/26687/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java: Line 299: CommandBase command, Line 300: AsyncTaskCreationInfo asyncTaskCreationInfo, Line 301: VdcActionType parentCommand) { Line 302: VdcActionParametersBase parentParameters = command.getParentParameters(parentCommand); Line 303: AsyncTasks asyncTask = new AsyncTasks(parentCommand, would you like to simply add more arguments to the CTOR instead of calling setters? Line 304: AsyncTaskResultEnum.success, Line 305: AsyncTaskStatusEnum.running, Line 306: asyncTaskCreationInfo.getVdsmTaskId(), Line 307: parentParameters, -- To view, visit http://gerrit.ovirt.org/26687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied038b514f1285b4d46deff022beafd9dcfe5c29 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
