Vojtech Szocs has posted comments on this change. Change subject: core: [CDI] - Replace EJBs with CDI Singletons ......................................................................
Patch Set 9: Code-Review+1 (2 comments) Nice patch! http://gerrit.ovirt.org/#/c/19887/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 68: import java.util.ArrayList; Line 69: import java.util.List; Line 70: import java.util.concurrent.TimeUnit; Line 71: Line 72: @Startup Does javax.ejb.Startup annotation have any effect here? (I thought this is no longer an EJB component.) Line 73: @Singleton Line 74: @Interceptors({ ThreadLocalSessionCleanerInterceptor.class }) Line 75: public class Backend implements BackendInternal, BackendCommandObjectsHandler { Line 76: http://gerrit.ovirt.org/#/c/19887/9/backend/manager/modules/bll/src/main/resources/rebel.xml File backend/manager/modules/bll/src/main/resources/rebel.xml: Line 1: <?xml version="1.0" encoding="UTF-8"?> Line 2: <application xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://www.zeroturnaround.com"; xsi:schemaLocation="http://www.zeroturnaround.com http://www.zeroturnaround.com/alderaan/rebel-2_0.xsd";> Line 3: Line 4: <classpath> Line 5: <dir name="/home/rgolan/src/git/ovirt-engine/backend/manager/modules/bll/target/classes"> This seems like JRebel config file, do we need to track it in git? Line 6: </dir> Line 7: </classpath> Line 8: -- To view, visit http://gerrit.ovirt.org/19887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I126fa3f4240e81814ec9e902cb2e93ce364589ff Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
