Lior Vernia has uploaded a new change for review. Change subject: webadmin: Swap KEYPRESS for KEYDOWN in ListModelListBox ......................................................................
webadmin: Swap KEYPRESS for KEYDOWN in ListModelListBox There are issues with the KEYPRESS event not being called - swapping it for KEYDOWN should be good enough a solution in this case. Change-Id: I006cb4e5e429ada629c23204c72d6cabb6df24bb Bug-Url: https://bugzilla.redhat.com/987916 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/26845/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java index b2dcce4..7837397 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java @@ -6,8 +6,8 @@ import com.google.gwt.editor.client.adapters.TakesValueEditor; import com.google.gwt.event.dom.client.DomEvent; import com.google.gwt.event.dom.client.KeyCodes; +import com.google.gwt.event.dom.client.KeyDownEvent; import com.google.gwt.event.dom.client.KeyDownHandler; -import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.event.dom.client.KeyPressHandler; import com.google.gwt.event.dom.client.KeyUpHandler; import com.google.gwt.event.shared.HandlerRegistration; @@ -33,10 +33,10 @@ */ public ListModelListBox(Renderer<T> renderer) { super(renderer); - addKeyPressHandler(new KeyPressHandler() { + addKeyDownHandler(new KeyDownHandler() { @Override - public void onKeyPress(KeyPressEvent event) { + public void onKeyDown(KeyDownEvent event) { int keyCode = event.getNativeEvent().getKeyCode(); if (keyCode == KeyCodes.KEY_DOWN || keyCode == KeyCodes.KEY_UP || keyCode == KeyCodes.KEY_RIGHT || keyCode == KeyCodes.KEY_LEFT) { -- To view, visit http://gerrit.ovirt.org/26845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I006cb4e5e429ada629c23204c72d6cabb6df24bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
