Omer Frenkel has posted comments on this change.

Change subject: core : Master reconstruct leads to inconsistent state  (#800839)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 552:                     String host = 
TransactionSupport.executeInScope(TransactionScopeOption.Suppress, new 
TransactionMethod<String>() {
ok i went over the code, seems that most updates are done in new transactions 
(require new), is it still nessecary now that there is no transaction at all? 
(except HandleSelectedVdsForSPM method which do the updates in the current 
transaction)

--
To view, visit http://gerrit.ovirt.org/4862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93b1e8931fc68b1233dd562a3776ca29494d5976
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to