Ravi Nori has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26337/5/packaging/dbscripts/upgrade/03_05_0160_add_command_entity_table.sql File packaging/dbscripts/upgrade/03_05_0160_add_command_entity_table.sql: Line 2: CREATE TABLE command_entities Line 3: ( Line 4: command_id UUID NOT NULL, Line 5: command_type integer NOT NULL, Line 6: parent_command_id UUID, > I would consider indexing parent command_id. Having the fk constraint is breaking a lot of things so decided to remove it in the latest patch. Async tasks insertion does not insert parent command but only child command Line 7: data TEXT, Line 8: created_at TIMESTAMP WITH TIME ZONE, Line 9: CONSTRAINT pk_command_entities PRIMARY KEY(command_id) -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
