Vojtech Szocs has posted comments on this change. Change subject: webadmin: feedback tooltip ......................................................................
Patch Set 2: > That is certainly well out of scope for this particular patch. You are right, I should've probably send it to devel mailing list as a more general suggestion. I just wanted to say that we should think about having consistent tooltip infra. My previous comment is indeed way out of scope for this patch. > I can make the decorator class and apply it to my label. Then we can make > another patch to apply the decorator to all the other classes. Sounds good, you can also proceed with current approach and introduce decorator in a separate patch. Whatever works best for you. -- To view, visit http://gerrit.ovirt.org/25703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id17d0addf99645d2c8fb6f54ccafa0d4d688d177 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
